Skip to content

Fix for #842 #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2025
Merged

Fix for #842 #843

merged 3 commits into from
Mar 13, 2025

Conversation

torfjelde
Copy link
Member

Ref: #842

torfjelde and others added 3 commits March 13, 2025 10:21
@torfjelde
fix for #842
5846a46
@torfjelde
bump patch version
b05047b
@torfjelde @github-actions
Update src/varinfo.jl
3d3cafe 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025 •
edited
Loading

Benchmark Report for Commit 3d3cafececbed37b22c847432c5a764b03a620f4

Computer Information

Julia Version 1.11.4
Commit 8561cc3d68d (2025-03-10 11:36 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.8 |                 1.5 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                606.5 |                41.1 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                350.9 |                53.6 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1199.1 |                27.6 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3880.0 |                20.3 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1438.8 |                29.5 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                936.7 |                 5.6 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5383.5 |                 5.2 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1086.6 |                 8.3 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              59842.3 |                 4.5 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8749.5 |                 9.7 |
|               Dynamic |        10 |    mooncake |             typed |   true |                123.5 |                12.3 |
|              Submodel |         1 |    mooncake |             typed |   true |                 25.6 |                 7.3 |
|                   LDA |        12 | reversediff |             typed |   true |                455.3 |                 4.7 |

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (5c89efc) to head (3d3cafe).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files          34       34           
  Lines        3830     3830           
=======================================
  Hits         3239     3239           
  Misses        591      591

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13832435887

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.658%
Totals Coverage Status
Change from base Build 13812612392: 0.0%
Covered Lines: 3239
Relevant Lines: 3826
💛 - Coveralls

@torfjelde torfjelde requested review from mhauru and penelopeysm March 13, 2025 15:39
penelopeysm
penelopeysm approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @torfjelde for picking this up so quickly 😄

@torfjelde torfjelde added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 4bc43a4 Mar 13, 2025
18 checks passed
@torfjelde torfjelde deleted the torfjelde/fix-for-issue-842 branch March 13, 2025 16:23
@penelopeysm penelopeysm mentioned this pull request Mar 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penelopeysm penelopeysm penelopeysm approved these changes

@mhauru mhauru Awaiting requested review from mhauru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torfjelde @coveralls @penelopeysm